feat: add require-homepage rule#1480
Merged
michaelfaith merged 4 commits intomichaelfaith:mainfrom Dec 31, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1480 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 28 28
Lines 575 575
Branches 169 169
=======================================
Hits 560 560
Misses 1 1
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
michaelfaith
requested changes
Dec 31, 2025
Owner
michaelfaith
left a comment
michaelfaith
left a comment
There was a problem hiding this comment.
Thanks for the contribution! 🚀 Just a couple small requests from me.
michaelfaith
approved these changes
Dec 31, 2025
Owner
michaelfaith
left a comment
michaelfaith
left a comment
There was a problem hiding this comment.
Looks good! Thanks again 👍
Owner
|
@all-contributors please add @marcalexiei for code |
Contributor
|
I've put up a pull request to add @marcalexiei! 🎉 |
michaelfaith
pushed a commit
that referenced
this pull request
Dec 31, 2025
Adds @marcalexiei as a contributor for code. This was requested by michaelfaith [in this comment](#1480 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
michaelfaith
added a commit
that referenced
this pull request
Jan 1, 2026
🤖 I have created a release *beep* *boop* --- ## [0.87.1](v0.87.0...v0.87.1) (2025-12-31) ### Features * add require-homepage rule ([#1480](#1480)) ([0d895ff](0d895ff)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> Co-authored-by: michael faith <michaelfaith@users.noreply.github.com>
michaelfaith
pushed a commit
that referenced
this pull request
Jan 1, 2026
<!-- 👋 Hi, thanks for sending a PR to eslint-plugin-package-json! 🗂 Please fill out all fields below and make sure each item is true and [x] checked. Otherwise we may not be able to review your PR. --> ## PR Checklist - [ ] Addresses an existing open issue: fixes #000 - [ ] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/.github/CONTRIBUTING.md) were taken > [!NOTE] > Actually this is a followup of #1480 ## Overview I noticed that were some typescript errors in - `eslint.config.ts` - `perfectionist.configs` is possibly undefined - `vitest.config.ts` - `coverage.all` option no longer is not a valid option in `vitest@4` To fix them I added `*.config.ts` to `tsconfig#includes` and updated `languageOptions.parserOptions.projectService` accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Add
homepageto properties listed insrc/rules/require-properties.ts