feat: enable ignorePrivate on more require- rules#1607
Merged
michaelfaith merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
This change enables `ignorePrivate` by default for the following, more public-oriented, require rules - `require-bugs` - `require-homepage` - `require-keywords`
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1607 +/- ##
=======================================
Coverage 96.84% 96.84%
=======================================
Files 28 28
Lines 603 603
Branches 179 179
=======================================
Hits 584 584
Misses 3 3
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
michaelfaith
pushed a commit
that referenced
this pull request
Feb 27, 2026
🤖 I have created a release *beep* *boop* --- ## [0.89.2](v0.89.1...v0.89.2) (2026-02-27) ### 🚀 Features * enable `ignorePrivate` on more `require-` rules ([#1607](#1607)) ([4004220](4004220)) ### 🩹 Bug Fixes * **deps:** update `package-json-validator` to 1.0.1 ([#1599](#1599)) ([8550731](8550731)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
|
🎉 This is included in version v0.89.2 🎉 The release is available on: Cheers! 📦🚀 |
michaelfaith
added a commit
that referenced
this pull request
Mar 4, 2026
<!-- 👋 Hi, thanks for sending a PR to eslint-plugin-package-json! 🗂 Please fill out all fields below and make sure each item is true and [x] checked. Otherwise we may not be able to review your PR. --> ## PR Checklist - [x] Addresses an existing open issue: fixes #1605 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/.github/CONTRIBUTING.md) were taken ## Overview This change enables `ignorePrivate` by default for the following, more public-oriented, require rules - `require-bugs` - `require-homepage` - `require-keywords` I also updated all the docs for the require rules to auto-generate the options.
michaelfaith
pushed a commit
that referenced
this pull request
Mar 4, 2026
🤖 I have created a release *beep* *boop* --- ## [1.0.0-beta.1](v1.0.0-beta.0...v1.0.0-beta.1) (2026-03-04) ### 🚀 Features * enable `ignorePrivate` on more `require-` rules ([#1607](#1607)) ([a187fa8](a187fa8)) ### 🩹 Bug Fixes * update repo references ([#1613](#1613)) ([079d3af](079d3af)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
ignorePrivatefor more require rules #1605status: accepting prsOverview
This change enables
ignorePrivateby default for the following, more public-oriented, require rulesrequire-bugsrequire-homepagerequire-keywordsI also updated all the docs for the require rules to auto-generate the options.