Skip to content

Add version check for transformers package when trying to import bettertransformers #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wirthual wants to merge 4 commits into from
Closed

Add version check for transformers package when trying to import bettertransformers #600

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9800cc7
add version check for transformers package
wirthual Jun 15, 2025
274c174
minor improvements
wirthual Jun 15, 2025
393d8fd
Merge branch 'main' into add-version-check
wirthual Jun 16, 2025
5647cab
Merge branch 'main' into add-version-check
wirthual Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions libs/infinity_emb/infinity_emb/transformer/acceleration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,18 @@
from infinity_emb._optional_imports import CHECK_OPTIMUM, CHECK_TORCH, CHECK_TRANSFORMERS
from infinity_emb.primitives import Device

bettertransformer_available = False
if CHECK_OPTIMUM.is_available:
from optimum.bettertransformer import ( # type: ignore[import-untyped]
BetterTransformer,
BetterTransformerManager,
)
from importlib.metadata import version
transformers_version_string = version('transformers')
Copy link

Copilot AI Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing the version string by splitting and int-casting can fail on pre-release or metadata tags. Consider using packaging.version.parse for robust comparisons.

Copilot uses AI. Check for mistakes.
transformers_version = tuple([int(number) for number in transformers_version_string.split(".")])
if transformers_version < (4,49,0):
from optimum.bettertransformer import ( # type: ignore[import-untyped]
BetterTransformer,
BetterTransformerManager,
)
bettertransformer_available = True


if CHECK_TORCH.is_available:
import torch
Expand All @@ -36,6 +43,9 @@ def check_if_bettertransformer_possible(engine_args: "EngineArgs") -> bool:
"""verifies if attempting conversion to bettertransformers should be checked."""
if not engine_args.bettertransformer:
return False

if not bettertransformer_available:
return False

config = AutoConfig.from_pretrained(
pretrained_model_name_or_path=engine_args.model_name_or_path,
Expand All @@ -50,6 +60,12 @@ def to_bettertransformer(model: "PreTrainedModel", engine_args: "EngineArgs", lo
if not engine_args.bettertransformer:
return model

if not bettertransformer_available:
logger.warning(
"BetterTransformer is not available for transformers package > 4.49"
)
return model

if engine_args.device == Device.mps or (
hasattr(model, "device") and model.device.type == "mps"
):
Expand Down