Skip to content

fixed function marketSideEquals #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tom-Kc wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed function marketSideEquals #148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
991c86f
fixed function marketSideEquals
Jul 7, 2017
0684674
Merge pull request #1 from tom-Kc/tom-Kc-patch-1
Jul 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/common/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class GatewayMarketTrade implements ITimestamped {
export function marketSideEquals(t: MarketSide, other: MarketSide, tol?: number) {
tol = tol || 1e-4;
if (other == null) return false;
return Math.abs(t.price - other.price) > tol && Math.abs(t.size - other.size) > tol;
return Math.abs(t.price - other.price) < tol && Math.abs(t.size - other.size) < tol;
}

export class Market implements ITimestamped {
Expand Down Expand Up @@ -352,4 +352,4 @@ export class TargetBasePositionValue {

export class CancelAllOrdersRequest {
constructor() {}
}
}