You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This package is almost exactly a clone of bytestring-trie, so I'm trying not to diverge from it. If you get it added to bytestring-trie, I'll update this repo. Otherwise, I think this should go in a text-trie-ext or similar utilities library. (I'd be happy to link to it from the readme if you end up going that route.)
Actually, I'm using both bytestring-trie and text-trie.
I've already requested PR to bytestring-trie after this PR for text-trie. But the repository seems not to be managed well...
Anyway, I don't think that making a new package text-trie-ext is a good idea because I couldn't access some of the constructors by importing Data.Trie.Text.Internal (for example, Branch) for pattern matching.
If I couldn't access it, the function would not be efficient.
If you don't mind and couldn't wait for bytestring-trie, then please update your repo. (I'm now using my own branch it with etra-deps)
bytestring-trie have been updated which covers my old PR from v0.2.6.
Could you update your text-trie from on this new version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could you add this new function?
I've been used
text-triefor many use case, and I implement a function for myself likeHowever, because it traverses every deleting target entries, this version is too slow.
Could you add my implementation in the
Data.Trie.Text.Internal?I'm not sure that the function's name and actual implementation is proper for your package.
If you care, please rename&change it.