Skip to content

Commit 7824e60

Browse files
committed
Manual neutral summaries should block generated summaries
1 parent 52563b0 commit 7824e60

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

csharp/ql/lib/semmle/code/csharp/dataflow/internal/ExternalFlow.qll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -551,6 +551,10 @@ private class SummarizedCallableAdapter extends SummarizedCallable {
551551
exists(Provenance provenance |
552552
interpretSummary(this, input, output, kind, provenance) and
553553
provenance.isGenerated()
554+
) and
555+
not exists(Provenance provenance |
556+
interpretNeutral(this, "summary", provenance) and
557+
provenance.isManual()
554558
)
555559
}
556560

java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -528,6 +528,10 @@ private class SummarizedCallableAdapter extends SummarizedCallable {
528528
exists(Provenance provenance |
529529
summaryElement(this, input, output, kind, provenance) and
530530
provenance.isGenerated()
531+
) and
532+
not exists(Provenance provenance |
533+
neutralElement(this, "summary", provenance) and
534+
provenance.isManual()
531535
)
532536
}
533537

0 commit comments

Comments
 (0)