Skip to content

Feature/add i18n#5

Merged
michaelschoenbaechler merged 1 commit intomainfrom
feature/add-i18n
May 26, 2025
Merged

Feature/add i18n#5
michaelschoenbaechler merged 1 commit intomainfrom
feature/add-i18n

Conversation

@dharzheim
Copy link
Collaborator

No description provided.

@michaelschoenbaechler
Copy link
Owner

Thanks for your contribution. I’m looking forward to see it available in all official languages. Transloco was a great choice.

A few open questions:

  • Was it intentional to not fetch language-specific data from the API? For example, using a filter like { Language: lang } in services?
  • Is it okay not to use the official translations from parlament.ch? For instance, business.detailText translates Motionstext as Texte animé, which doesn’t seem right, since a motion should still be called a motion (see: https://www.parlament.ch/fr/ratsbetrieb/suche-curia-vista).
  • Do we need simple-git? Was there a problem reading the file with fs?
  • Is there a way to detect the default language based on the device settings?

Copy link
Owner

@michaelschoenbaechler michaelschoenbaechler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash before merge

@michaelschoenbaechler michaelschoenbaechler merged commit 2147e1e into main May 26, 2025
2 checks passed
@michaelschoenbaechler michaelschoenbaechler deleted the feature/add-i18n branch May 26, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants