fix: watch position interval change from hardcode value to user input #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change updates the watchPosition configuration to correctly respect the user-provided interval option.
Previously, the location update interval was hardcoded to 1000ms, which caused the interval option to be ignored. As a result:
Location updates were triggered primarily when the distanceFilter threshold was crossed.
When distanceFilter was set to 0, updates were delivered every second, even if the user specified a longer interval (e.g., 30 seconds).
With this change, the interval value supplied by the user is now correctly applied to watchPosition. This allows users to control how frequently location updates are received, independent of distance changes (for example, receiving updates every 30 seconds with distanceFilter: 0).
Please find my contact : mdmasiuddin144@gmail.com
Test Plan
Ran the local unit test