Skip to content

Includes dependencies in ESM build#423

Open
sntran wants to merge 1 commit intomichalsnik:nextfrom
sntran-contrib:esm-include-deps
Open

Includes dependencies in ESM build#423
sntran wants to merge 1 commit intomichalsnik:nextfrom
sntran-contrib:esm-include-deps

Conversation

@sntran
Copy link

@sntran sntran commented Nov 14, 2018

Related Issue

#422

Your solution

Removed external option for Rollup and added resolve and commonjs plugins.

How Has This Been Tested?

Used the new ESM bundle on the browser as a module, and AOS is working. As it does not change any source code, it should work fine as is.

<script type="module">
  import AOS from "./node_modules/aos/dist/aos.esm.js";
  AOS.init({});
</script>

@bavarianbytes
Copy link

Is this project dead? Would need that too. Want to use AOS as native ESM module. Therefore deps should be included in the ESM version of AOS.

@egidiusmengelberg
Copy link

Yeah I need this too. I'm using this library with Nuxt 3 and keep having issues with imports. egidiusmengelberg/nuxt-aos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants