Skip to content

fix window scroll handler leaks #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hkhere wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix window scroll handler leaks #643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/js/aos.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ let options = {
// http://browserhacks.com/#hack-e71d8692f65334173fee715c222cb805
const isBrowserNotSupported = () => document.all && !window.atob;

// current window scroll handler
let currentScrollHandler
const initializeScroll = function initializeScroll() {
// Extend elements objects in $aosElements with their positions
$aosElements = prepare($aosElements, options);
Expand All @@ -57,12 +59,13 @@ const initializeScroll = function initializeScroll() {
/**
* Handle scroll event to animate elements on scroll
*/
window.addEventListener(
'scroll',
throttle(() => {
handleScroll($aosElements, options.once);
}, options.throttleDelay)
);
if (currentScrollHandler) {
window.removeEventListener('scroll', currentScrollHandler)
}
currentScrollHandler = throttle(() => {
handleScroll($aosElements, options.once);
}, options.throttleDelay)
window.addEventListener('scroll', currentScrollHandler)

return $aosElements;
};
Expand Down