fix: amend USBTMCCommonInterface to be os.O_RDWR in tmc in samps module#70
Merged
michealroberts merged 1 commit intomainfrom Dec 2, 2025
Merged
Conversation
fix: amend USBTMCCommonInterface to be os.O_RDWR in tmc in samps module
There was a problem hiding this comment.
Pull request overview
This PR fixes the USBTMC device initialization by ensuring the timeout ioctl is properly executed during device opening. The key changes address a bug where the timeout was never actually set in the kernel driver during initialization.
- Removed
os.O_NONBLOCKflag since blocking mode withselect()is the correct pattern for this implementation - Fixed timeout initialization by reordering the
set_timeout()call to occur after_is_open = True, ensuring the kernel ioctl is actually executed - Changed error handling in
set_timeout()to silently return on ENOTTY/EINVAL, allowing the code to gracefully handle PTYs and older kernels that don't support USBTMC timeout ioctls
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: amend USBTMCCommonInterface to be os.O_RDWR in tmc in samps module