use semver #7
Open
use semver #7
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* include proper versions for deps * bump to 1.0.0-alpha (breaking changes allowed) If not a proper bump to 1.0.0-alpha this should at least be bumped to 0.1.0 so that there's some scale to version changes.
michielbdejong
added a commit
that referenced
this pull request
May 28, 2015
Owner
|
OK, can you test current master (5d4b1e6) and confirm it works? Then I'll add a changelog file and tag 0.1.0. We'll do the common "pre-semver" practice to bump up the pre-1.0 minor version whenever there is a breaking change in the API. So we'll stay on |
Author
|
I'm round-robin-ing between the aspects of the project I'm working on. Eventually I will get back to this and test it - just so you know that I haven't forgotten. |
Owner
|
I now pushed 0.0.5 to npm with the 'deprecated' message in the readme: https://www.npmjs.com/package/node-letsencrypt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not a proper bump to 1.0.0-alpha this should at least be bumped to 0.1.0 so that there's some scale to version changes.