Add simple DoRequest so clients can implement auth#12
Open
belak wants to merge 3 commits intomichiwend:masterfrom
Open
Add simple DoRequest so clients can implement auth#12belak wants to merge 3 commits intomichiwend:masterfrom
belak wants to merge 3 commits intomichiwend:masterfrom
Conversation
Author
|
After looking at this, I think the proper way of handling this would be to create something like |
Owner
|
Hej @belak I'm sorry for not getting back to you. I was quite busy and didn't look at this project in a while. I will review your PR asap! thank you very much for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is so clients can implement Basic or Digest auth. The spec mentions digest auth, but the server I'm using also supports basic auth.
So, you can do something like this:
However, I'm aware this is a hack... and I'm not even sure if it can be used for Digest auth... if you have any suggestions as to a better way to do this, I'd be happy to do that instead.