Skip to content

Problems with table names containing character '%', related issue #87 #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: azure-2.1
Choose a base branch
from
Open

Problems with table names containing character '%', related issue #87 #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions sql_server/pyodbc/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,9 +495,13 @@ def format_sql(self, sql, params):
sql = smart_str(sql, self.driver_charset)

# pyodbc uses '?' instead of '%s' as parameter placeholder.
# SQL identifiers (consequently table names) can contain special characters if surrounded by brackets '[...]'
# Replace only those placeholders:'%, %% %s etc.' which are not surrounded by brackets.
# This is not complete solution, there may be problems with string literals in SQL etc.
if params is not None:
sql = sql % tuple('?' * len(params))

pattern = '''(?<![\[\]])\%[sbcdoxXn%]?(?![^\[\]]*\])'''
sql = re.sub(pattern,'?',sql)

return sql

def format_params(self, params):
Expand Down