Skip to content

Proposal for DeviceInstance::MakeExceptionForCode( ) #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SutterBruce wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Proposal for DeviceInstance::MakeExceptionForCode( ) #656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions MMCore/Devices/DeviceInstance.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,9 @@ DeviceInstance::MakeException() const
CMMError
DeviceInstance::MakeExceptionForCode(int code) const
{
return CMMError("Error in device " + ToQuotedString(GetLabel()) + ": " +
GetErrorText(code) + " (" + ToString(code) + ")");
// 2025.05.20.bp: Propose passing exception code as 2nd parameter to constructor, overriding default.
return CMMError("Error in device " + ToQuotedString(GetLabel()) + ": " +
GetErrorText(code) + " (" + ToString(code) + ")", (CMMError::Code)code);
}

void
Expand Down