Skip to content

Support TLV56x8 in the Arduino device adapter #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asincerity wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support TLV56x8 in the Arduino device adapter #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69fc14e
Add files via upload
asincerity Aug 29, 2025
77db499
Update fmt.
asincerity Sep 26, 2025
d8a7f96
add firmware
asincerity Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 36 additions & 4 deletions DeviceAdapters/Arduino/Arduino.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ const char* g_DeviceNameArduinoDA1 = "Arduino-DAC1";
const char* g_DeviceNameArduinoDA2 = "Arduino-DAC2";
const char* g_DeviceNameArduinoInput = "Arduino-Input";
const char* g_DeviceNameArduinoMagnifier = "Arduino-Magnifier";

// Define a new device name
const char* g_DeviceNameArduinoDA3 = "Arduino-DAC3";
const char* g_DeviceNameArduinoDA4 = "Arduino-DAC4";

// Global info about the state of the Arduino. This should be folded into a class
const int g_Min_MMVersion = 1;
Expand All @@ -56,6 +58,8 @@ MODULE_API void InitializeModuleData()
RegisterDevice(g_DeviceNameArduinoShutter, MM::ShutterDevice, "Shutter");
RegisterDevice(g_DeviceNameArduinoDA1, MM::SignalIODevice, "DAC channel 1");
RegisterDevice(g_DeviceNameArduinoDA2, MM::SignalIODevice, "DAC channel 2");
RegisterDevice(g_DeviceNameArduinoDA3, MM::SignalIODevice, "DAC channel 3"); // add new
RegisterDevice(g_DeviceNameArduinoDA4, MM::SignalIODevice, "DAC channel 4"); // add new
RegisterDevice(g_DeviceNameArduinoInput, MM::GenericDevice, "ADC");
RegisterDevice(g_DeviceNameArduinoMagnifier, MM::MagnifierDevice, "Magnifier(needs ADC)");
}
Expand Down Expand Up @@ -85,6 +89,14 @@ MODULE_API MM::Device* CreateDevice(const char* deviceName)
{
return new CArduinoDA(2); // channel 2
}
else if (strcmp(deviceName, g_DeviceNameArduinoDA3) == 0) // add new
{
return new CArduinoDA(3); // channel 3
}
else if (strcmp(deviceName, g_DeviceNameArduinoDA4) == 0) // add new
{
return new CArduinoDA(4); // channel 4
}
else if (strcmp(deviceName, g_DeviceNameArduinoInput) == 0)
{
return new CArduinoInput;
Expand Down Expand Up @@ -358,6 +370,8 @@ int CArduinoHub::DetectInstalledDevices()
peripherals.push_back(g_DeviceNameArduinoMagnifier);
peripherals.push_back(g_DeviceNameArduinoDA1);
peripherals.push_back(g_DeviceNameArduinoDA2);
peripherals.push_back(g_DeviceNameArduinoDA3);
peripherals.push_back(g_DeviceNameArduinoDA4);
for (size_t i=0; i < peripherals.size(); i++)
{
MM::Device* pDev = ::CreateDevice(peripherals[i].c_str());
Expand Down Expand Up @@ -1120,7 +1134,7 @@ CArduinoDA::CArduinoDA(int channel) :
volts_(0.0),
gatedVolts_(0.0),
channel_(channel),
maxChannel_(2),
maxChannel_(4),
gateOpen_(true)
{
InitializeDefaultErrorMessages();
Expand All @@ -1145,8 +1159,25 @@ CArduinoDA::CArduinoDA(int channel) :
CPropertyAction* pAct = new CPropertyAction(this, &CArduinoDA::OnMaxVolt);
CreateProperty("MaxVolt", "5.0", MM::Float, false, pAct, true);

name_ = channel_ == 1 ? g_DeviceNameArduinoDA1 : g_DeviceNameArduinoDA2;

switch (channel_) {
case 1:
name_ = g_DeviceNameArduinoDA1;
break;
case 2:
name_ = g_DeviceNameArduinoDA2;
break;
case 3:
name_ = g_DeviceNameArduinoDA3;
break;
case 4:
name_ = g_DeviceNameArduinoDA4;
break;
default:
// 如果channel_不在1到4之间，可以设置一个默认值或处理错误
name_ = "UnknownChannel";
break;
}

// Description
int nRet = CreateProperty(MM::g_Keyword_Description, "Arduino DAC driver", MM::String, true);
assert(DEVICE_OK == nRet);
Expand Down Expand Up @@ -1960,3 +1991,4 @@ void ArduinoInputMonitorThread::Start()
activate();
}


Loading