Skip to content

Disconnect zones from source when stream disconnects #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SteveMicroNova wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Disconnect zones from source when stream disconnects #1048

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a53828
Disconnect zones from source when stream disconnects
SteveMicroNova Jun 2, 2025
fbc2c17
Linting
SteveMicroNova Jun 2, 2025
f9a8b0c
Decouple set_source endpoint from get_zones endpoint
SteveMicroNova Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions amplipi/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,12 @@ def set_source(update: models.SourceUpdate, ctrl: Api = Depends(get_ctrl), sid:
valid_update = update.copy()
valid_update.input = f'stream={defaults.RCAs[sid]}'
logging.warning(f'correcting deprecated use of RCA inputs from {update} to {valid_update}')
if update.input == 'None':
# Disconnect zones from inactive sources
zones = ctrl.get_state().zones
connected_zones = [zone.id for zone in zones["zones"] if zone.source_id == sid and zone.id is not None] # zone.id should never actually be none, but the linter worries about it
if connected_zones:
ctrl.set_zones(models.MultiZoneUpdate(zones=connected_zones, update=models.ZoneUpdate(source_id=-1)))
return code_response(ctrl, ctrl.set_source(sid, update))


Expand Down
Loading