Synchronize airplay volume#1071
Draft
SteveMicroNova wants to merge 49 commits intoSpotifyVolumeReflectionfrom
Draft
Synchronize airplay volume#1071SteveMicroNova wants to merge 49 commits intoSpotifyVolumeReflectionfrom
SteveMicroNova wants to merge 49 commits intoSpotifyVolumeReflectionfrom
Conversation
SteveMicroNova
commented
Nov 19, 2025
Comment on lines
+91
to
+93
| 'drift_in_seconds': 2, # allow this number of frames of drift away from exact synchronisation before attempting to correct it | ||
| 'resync_threshold_in_seconds': 0, # a synchronisation error greater than this will cause resynchronisation; 0 disables it | ||
| 'log_verbosity': "diagnostics", # "none" means no debug verbosity, "diagnostics" is most verbose. |
Contributor
Author
There was a problem hiding this comment.
The log file contained warnings about all of these values, it now has no complaints
SteveMicroNova
commented
Nov 19, 2025
This was
linked to
issues
Nov 19, 2025
SteveMicroNova
force-pushed
the
AirplayVolSync
branch
2 times, most recently
from
772cb10 to
ad8df1e
Compare
Contributor
Author
|
This will require some internal debate before merging, but I'm going to suggest this is ready for review even if not ready for merging |
SteveMicroNova
force-pushed
the
SpotifyVolumeReflection
branch
from
7de343e to
e83de61
Compare
SteveMicroNova
force-pushed
the
SpotifyVolumeReflection
branch
from
e83de61 to
7fc8fd7
Compare
SteveMicroNova
force-pushed
the
AirplayVolSync
branch
4 times, most recently
from
94d957b to
672fbaf
Compare
SteveMicroNova
force-pushed
the
SpotifyVolumeReflection
branch
from
9e275c2 to
39d9455
Compare
5 tasks
Add more values to models.py to track the min and max overflow
… most of the changes to the metadata script
…and linting practices
Change names of attributes in spotify_connect.py Update documentation in volume_synchronizer.py
Change variable names Add VolEvent enum
SteveMicroNova
force-pushed
the
SpotifyVolumeReflection
branch
from
24a5664 to
4d2b723
Compare
SteveMicroNova
force-pushed
the
AirplayVolSync
branch
from
672fbaf to
66e537d
Compare
Add more docs Rename some classes, attributes, and variables
SteveMicroNova
force-pushed
the
AirplayVolSync
branch
from
cc23833 to
4cfeb14
Compare
SteveMicroNova
commented
Dec 4, 2025
Comment on lines
+55
to
+57
| # In any future MPRIS based volume synchronizers, you can check if self.mpris.CanControl is true and then potentially directly set self.mpris.Volume | ||
| # Note that we cannot do this due to this line: <property name='Volume' type='d' access='read'/> | ||
| # That exists in the MPRIS config xml at https://github.com/mikebrady/shairport-sync/blob/master/org.mpris.MediaPlayer2.xml |
Contributor
Author
There was a problem hiding this comment.
We'll either have to make a PR in shairport-sync or move to a new implementation to make this vol sync a good user experience
Contributor
There was a problem hiding this comment.
Since shareport-sync is extremely well maintained I would suggest the PR route.
SteveMicroNova
force-pushed
the
AirplayVolSync
branch
from
4c543f7 to
7b41571
Compare
SteveMicroNova
force-pushed
the
SpotifyVolumeReflection
branch
2 times, most recently
from
61789c5 to
6d89922
Compare
SteveMicroNova
force-pushed
the
SpotifyVolumeReflection
branch
9 times, most recently
from
3edcbfd to
6cbee9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change intend to accomplish?
Does the same as #1063, but for airplay
Airplay does not allow outside sources change the volume of the airplay host, so it's a one way street this time
Checklist
./scripts/test