Topic wildcard #2786
Open
Topic wildcard #2786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [fix] micro#2431 http transport data race issue
# Conflicts: # client/rpc_stream.go
# Conflicts: # plugins/config/source/etcd/etcd.go
Ability to send messages while receiving. Icreased r channel limit to 100 to more fluently communication. Do not dropp sent request if r channel is full.
|
I merged your previous PR so you now have a merge conflict here |
|
Thanks, I will resolved it |
# Conflicts: # server/rpc_events.go
|
Resolved. |
asim
approved these changes
Jun 4, 2025
|
Weirdly no tests are being run for this. Are you taking into account the need for grpc server changes since you've changed the router interface? |
|
I admit I never looked at the grpc part because we don't use it. And since there is no test for it, I didn't touch it, because we can't test it with our own system. |
|
OK well I think firstly you probably need to resync master and squash all this because theres like commits from 4 years ago, and I need to see the tests run and you'll see grpc server fail because of the change in interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to use filter subject in topic name e.g. factory-events..