feat: dynamic destination path selection based on free space#174
Open
etherealNest wants to merge 3 commits intomicro5k:mainfrom
Open
feat: dynamic destination path selection based on free space#174etherealNest wants to merge 3 commits intomicro5k:mainfrom
etherealNest wants to merge 3 commits intomicro5k:mainfrom
Conversation
Signed-off-by: Mykyta <etherealnested@gmail.com>
Signed-off-by: Mykyta <etherealnested@gmail.com>
etherealNest
changed the title
Member
|
Hi, I have introduced DEST_PATH to support the installation on a different partition but there are still some places of the code that need to be adjusted so it need additional changes before it can be safely enabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some devices like the Pixel 8, the /system partition is often completely full out of the box. Attempting to install microG there causes the script to fail.
Pull request adds a simple check after extracting the files. It looks at how much space is needed and tries to install to /product, /system_ext, or /vendor if /system doesn't have enough free space.