First translation sync #576
Conversation
|
Preview build will be at |
microbit-grace
changed the title
This reverts commit 329e51f.
More thought needed as to how to get language from embedded MakeCode to tool. Changing language works locally, but not in a deployed version. MakeCode reloads the iframe and lang param used to embed MakeCode is used to determine the language instead of using what the user selected.
lang/ui.en.json
Outdated
| "defaultMessage": "MakeCode block: on ML {actionName} start, show icon {iconName}", | ||
| "description": "Makecode default block alt text" |
There was a problem hiding this comment.
Currently I only use the translated "MakeCode block" portion of this string to compose the alt text (See CodeViewDefaultBlock.tsx line 56-65). Shall I manually trim the defaultMessages of all the "makecode-block-default-alt" in ui.xx.json so that only MakeCode block is being translated?
There was a problem hiding this comment.
Let's just have the prefix as a string.
So change to ID makecode-block-alt-prefix
text is just "MakeCode block:"
description is "Makecode block alt text prefix"
Then update the code to use that more straightforwardly.
There was a problem hiding this comment.
Code change looks good, thanks. Will try in a mo then merge.
There was a problem hiding this comment.
We can use a46efe6 to reinstate these in Crowdin.
Uh oh!
There was an error while loading. Please reload this page.