First-cut new session, connection, and testing model page E2E tests #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into mock-connections
Instantiation of bluetooth, usb, and radio bridge have been moved to App.tsx to ensure that this only happens once. Otherwise the instance mocked vs. the instance used would be different.
|
Preview build will be at |
microbit-grace
commented
Jan 23, 2025
microbit-grace
commented
Jan 23, 2025
microbit-grace
changed the title
microbit-grace
changed the title
src/e2e/app/connection-dialogs.ts
Outdated
| next?: "copy-pattern"; | ||
| } | ||
|
|
||
| const dialogTypes: { |
There was a problem hiding this comment.
I am unsure that the abstraction and looping here is a good idea...
Is there a simpler version of this that's more straight line test code? Does it have unacceptable duplication?
… revisiting later.
For some reasons the editJavaScript function is not running as expected in GH workflow.
microbit-grace
changed the title
microbit-matt-hillsdon
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes
Related issue: #554