Add in-context translations#600
Merged
microbit-matt-hillsdon merged 4 commits intomainfrom Jun 25, 2025
Merged
Conversation
microbit-grace
changed the title
Author
|
Clicking "Edit in MakeCode" seem to cause an error when doing in-context translation. Needs investigating. Seems to do with the Fixed (see comment below) |
microbit-grace
force-pushed
the
in-context-translations
branch
from
573c693 to
8f3b9d7
Compare
microbit-grace
commented
Jun 24, 2025
src/components/ButtonWithLoading.tsx
Outdated
Comment on lines
+4
to
+13
| // Workaround to avoid error caused by DOM changes when doing in-context translations. | ||
| export const ButtonWithLoading = ({ isLoading, ...props }: ButtonProps) => { | ||
| return ( | ||
| <Button | ||
| {...props} | ||
| isLoading={isLoading && !flags.translate} | ||
| disabled={isLoading} | ||
| /> | ||
| ); | ||
| }; |
Author
There was a problem hiding this comment.
Not very ideal. Suggestions on a better way of doing this welcome.
There was a problem hiding this comment.
Urgh. No good suggestions unfortunately.
microbit-grace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task (Private)
Add translate flag for changing the language to lol and for adding jipt script.