Replace smoothie fork with custom graph component#730
Draft
microbit-matt-hillsdon wants to merge 1 commit intoappsfrom
Draft
Replace smoothie fork with custom graph component#730microbit-matt-hillsdon wants to merge 1 commit intoappsfrom
microbit-matt-hillsdon wants to merge 1 commit intoappsfrom
Conversation
|
Preview build will be at |
microbit-matt-hillsdon
force-pushed
the
replace-smoothie
branch
from
4f7ff8b to
dd942b5
Compare
Author
|
Going to test the performance aspect of this on the office mini-PC which visibly struggles with the graph even on the Data Samples page. |
Aims for identical behaviour except for the recording lines which now show the recording in-progress rather than filling in the gap between start and end when the recording finishes. As a very minor tweak, for non-dashed lines we extend the line to the triangle rather than having the constant "catching up" effect from the next data sample. x/y/z move into the graph component rather than being rendered separately by React. That way they can have their position calculated without hacks. We keep a large enough buffer of data points to cope with window resizes (7000px+) without left truncating the graph when the window grows.
microbit-matt-hillsdon
force-pushed
the
replace-smoothie
branch
from
5ff937b to
3706149
Compare
Author
Performance is similar and not great. Worth spending some more time here I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is obviously targetting the wrong branch but I just wanted to try this as I was reminded how hacked in the recording time is. Still not perfect here (we really want to be told the times via a callback/subscription) but so much nicer to be in control of drawing the region and to render x/y/z along with the graph.