Wrap debug messages with a conditional compilation check. #23
Conversation
autogenerated.ts
Outdated
| return result; | ||
| }; | ||
|
|
||
| simulatorSendData(); |
There was a problem hiding this comment.
Also added this to the default autogenerated.ts, assuming it is needed, but not really tested it with the simulator itself.
Happy to remove it if it's better without it.
There was a problem hiding this comment.
We don't need this line. The simulatorRegister() call kicks things off. When the simulator is rendered it asks this extension for the data, so simulatorSendData() is only triggered in response.
There was a problem hiding this comment.
I think this line might still be generated in the autogenerated.ts file (or at least the files generated in the ml4f-test-header branch), should it be removed from there as well?
There was a problem hiding this comment.
Yes, good catch. Needs testing after the change, but I'm confident that's the right thing to do.
Very minor update so that the bigger blocks with
ifstatements only to print debug info are 100% not compiled whenML_DEBUG_PRINTis disabled (the compiler should take care of that, but this little extra check doesn't cost anything).No rush, can sit here until you have to for review.