Export startRunning function so it can be used in autogenerated.ts
#41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `isRunning` guard to `getCertainty` function
1 task
microbit-carlos
approved these changes
Jun 12, 2025
There was a problem hiding this comment.
Tested it locally and works great, thanks Rob!
I still think it's not ideal that ml.getCertainty() returns zero until the model is run for the first time after a couple of seconds from startup, but I think that's a separate thing that we might or might not change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
isRunningguard togetCertaintyfunctionThe intention is to call
startRunningat the end of theautogenerated.tsfile. This requires additional changes inml-trainer.See #40