Close flyout when navigating from toolbox #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This really helps with the route to the MakeCode sim and matches the behaviour on RaspberryPiFoundation#225
Deploying blockly-keyboard-experiment with
|
| Latest commit: |
9a14387
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://91c1abe8.blockly-keyboard-experimentation.pages.dev |
| Branch Preview URL: | https://close-flyout.blockly-keyboard-experimentation.pages.dev |
microbit-matt-hillsdon
added a commit
to microbit-matt-hillsdon/pxt
that referenced
this pull request
Feb 24, 2025
Collaborator
|
If you click outside of the toolbox after interacting with it, then click on the currently highlighted category, the category becomes de-selected instead of the flyout popping open. Screen.Recording.2025-02-25.110914.mp4 |
microbit-robert
approved these changes
Feb 26, 2025
Collaborator
microbit-robert
left a comment
microbit-robert
left a comment
There was a problem hiding this comment.
LGTM.
This change fixes the click behaviour noted above -> microbit-matt-hillsdon/pxt#20
So once they are both merged, all should be well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This really helps with the route to the MakeCode sim and matches the behaviour on RaspberryPiFoundation#225
MakeCode demo will be at https://close-flyout.review-pxt.pages.dev/ in ~10m.