Rename accessible blocks and only show option for project with blocks#55
Closed
microbit-grace wants to merge 2 commits intoblockly-12from
Closed
Rename accessible blocks and only show option for project with blocks#55microbit-grace wants to merge 2 commits intoblockly-12from
microbit-grace wants to merge 2 commits intoblockly-12from
Conversation
- Rename settings menu - Rename auth API key
Deploying review-pxt with
|
| Latest commit: |
28e7bcc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fae45fe0.review-pxt.pages.dev |
| Branch Preview URL: | https://rename-accessible-blocks.review-pxt.pages.dev |
microbit-grace
commented
May 28, 2025
Comment on lines
+86
to
+90
| const languageRestriction = pkg.mainPkg?.config?.languageRestriction; | ||
| const pyOnly = languageRestriction === pxt.editor.LanguageRestriction.PythonOnly; | ||
| const noBlocks = languageRestriction === pxt.editor.LanguageRestriction.NoBlocks; | ||
| const tsOnly = languageRestriction === pxt.editor.LanguageRestriction.JavaScriptOnly; | ||
| return !pyOnly && !tsOnly && !noBlocks && !!pkg.mainEditorPkg().files[pxt.MAIN_BLOCKS]; |
Collaborator
Author
There was a problem hiding this comment.
This logic is taken from https://github.com/microbit-matt-hillsdon/pxt/blob/blockly-12/webapp/src/container.tsx#L541 so that when the blocks toggle is visible, the keyboard controls would be visible. Not sure if this is the best way of doing it, suggestions welcomed!
Collaborator
Author
|
Close this PR as there's already one opened against master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO after blockly 12 + keyboard nav plugin update PR is merged