Focus trap window focus #80
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility with develop of Blockly on preview branch only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live demo https://focus-trap-window-focus.review-pxt.pages.dev/
Issue https://github.com/microbit-foundation/blockly-project/issues/87
When loading the Make:code editor initially, it is possible to end up in a state where the tour does not trap focus.
After investigating it, have not been able to pinpoint the exact cause. But by listening for general focusin events, we may be able to mitigate it. Obviously this is not a proper fix, but I didn't want to leave this with nothing. Even this doesn't seem to solve the problem every time. Presented for consideration.