Tab navigation improvement for the docs sidebar. #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glastonbridge
force-pushed
the
keyboard-docs-tab-order
branch
from
0dea4d8 to
128569b
Compare
Deploying review-pxt with
|
| Latest commit: |
73a6393
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://49298985.review-pxt.pages.dev |
| Branch Preview URL: | https://keyboard-docs-tab-order.review-pxt.pages.dev |
Collaborator
|
Yep, this is awkward, but works! I don't have any other suggestions so this is worth raising upstream and seeing if the MakeCode team have any other ideas, or will take it as is. @glastonbridge Please fix trailing spaces linting issues before raising PR. |
glastonbridge
force-pushed
the
keyboard-docs-tab-order
branch
from
128569b to
fb2c56f
Compare
…10772) Co-authored-by: Richard Knoll <[email protected]>
…screen minisim (microsoft#10773) Co-authored-by: Richard Knoll <[email protected]>
Co-authored-by: Richard Knoll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few usability boosts for the documents sidebar.
This does not make sense to do for documentation that contains multiple tab stops, as it would put the "open in new tab" button after every tab stop in the page. This is because the documentation, including the go back button, is an iframe and injecting a tab stop for open in new tab would be a bigger piece of work. I have however improved the focus outlines for this case.
Keyboard navigation help
Before
Screen.Recording.2025-07-14.at.15.58.53.mov
(pressing shift-tab to reach the button)
After
Screen.Recording.2025-07-14.at.16.01.17.mov
(pressing tab to reach the button)
Block Reference help
Before
Screen.Recording.2025-07-14.at.15.59.13.mov
After
Screen.Recording.2025-07-14.at.16.01.46.mov