[DRAFT - DO NOT MERGE] Use Blockly grid dropdown plugin #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying review-pxt with
|
| Latest commit: |
8ae7359
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://40cd5760.review-pxt.pages.dev |
| Branch Preview URL: | https://blockly-grid.review-pxt.pages.dev |
microbit-robert
commented
Jan 24, 2025
Comment on lines
+18
to
+21
| if (options.sort) { | ||
| options.data.sort() | ||
| } | ||
| super(text, {...options, columns: "4"}, validator); |
Collaborator
Author
There was a problem hiding this comment.
Not very nice. Also not sure why columns isn't already on the options object?
microbit-robert
commented
Jan 24, 2025
| const div = el as HTMLDivElement; | ||
| div.classList.add("blocklyDropDownButton"); | ||
|
|
||
| // We need to find where this occurs and handle it. |
Collaborator
Author
There was a problem hiding this comment.
And for the field_images.ts file as well.
Collaborator
Author
|
This is all rather horrible. The icon grid appears to be pixel perfect compared with the original. The gesture images are less so. There's something about the inherent browser styling of the button element that I can't completely match. The border colour is also wrong, but could be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A potential (low effort?) alternative to #8
The grid items look a bit odd due to a mixture of CSS that could be easily tweaked and the img attributes that MakeCode supply being taken seriously. The image data provided to the field editor is with height and width at 36px which is not straight forward to fix with CSS overrides as MakeCode normally uses 80% for this value rather than a hardcoded value in pixels.
Some things might be broken. I guess the proper way to do this is to have an internal FieldGridDropdown that extends Blockly.FieldGridDropdown, following the pattern for the FieldDropdown.