Skip to content

Fix: Broken Link of AsyncAPI , Postman collections, gRPC, OpenAPI , soapUI and Docker-compose installation#101

Merged
yada merged 3 commits intomicrocks:masterfrom
eyeaadil:Fix-gRPC-Link-clean
Feb 17, 2025
Merged

Fix: Broken Link of AsyncAPI , Postman collections, gRPC, OpenAPI , soapUI and Docker-compose installation#101
yada merged 3 commits intomicrocks:masterfrom
eyeaadil:Fix-gRPC-Link-clean

Conversation

@eyeaadil
Copy link
Copy Markdown
Contributor

Description

Fixed the broken Link of AsyncAPI ,Postman collections gRPC,OpenAPI , soapUI and Docker-compose installation in Create API mocks page.

Related issue(s)

Fixes: #94

cks page

Signed-off-by: eyeaadil <madil9227583@gmail.com>
…, gRPC and Docker-compose installation

Signed-off-by: eyeaadil <madil9227583@gmail.com>
Signed-off-by: eyeaadil <madil9227583@gmail.com>
@eyeaadil
Copy link
Copy Markdown
Contributor Author

@yada Now, can you review this?

@yada
Copy link
Copy Markdown
Member

yada commented Feb 17, 2025

@eyeaadil Yes, this new PR is ok, but the good practice was to update PR #95 and not close it to open a new one (we lose all history...). I'll merge this one, but please check how to update, and resolve conflict... because many open source projects will reject this type of new clean PR ;-)

Copy link
Copy Markdown
Member

@yada yada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with thanks

@yada yada merged commit 4f56cd3 into microcks:master Feb 17, 2025
4 checks passed
@github-actions
Copy link
Copy Markdown

🎉 @eyeaadil

You are now a Microcks community contributor! 💖

Thanks and congrats 🚀 on merging your first pull request! We are delighted and very proud of you! 👏

📢 If you're using Microcks in your organization, please add your company name to this list. 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

If you need to know why and how to add yourself to the list, please read the blog post "Join the Microcks Adopters list and Empower the vibrant open source Community 🙌"

Kudos and please keep going, we need you 🙌

🌟 ~~~~~~~~~ 🌟

📢 If you like Microcks, please ⭐ star ⭐ our repo to support it!

🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

@eyeaadil
Copy link
Copy Markdown
Contributor Author

@eyeaadil Yes, this new PR is ok, but the good practice was to update PR #95 and not close it to open a new one (we lose all history...). I'll merge this one, but please check how to update, and resolve conflict... because many open source projects will reject this type of new clean PR ;-)

@yada , Actually there was lots of mess up is done , that's why I deleted that PR.

@yada
Copy link
Copy Markdown
Member

yada commented Feb 17, 2025

Actually there was lot of mess up is done , that's why I deleted that PR.

I know, but this is something to take care of for the next PR. Only put in a PR what needs to be reviewed (not your tests...) and always keep and update the same PR: resolving conflict is very very common and will happen very often ;-)

@eyeaadil
Copy link
Copy Markdown
Contributor Author

Actually there was lot of mess up is done , that's why I deleted that PR.

I know, but this is something to take care of for the next PR. Only put in a PR what needs to be reviewed (not your tests...) and always keep and update the same PR: resolving conflict is very very common and will happen very often ;-)

Sure! In future I will take care of that.By the way Thank you so much for giving valuable insights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken Link of gRPC,OpenAPI,AsyncAPI,Postman collections and SoapUI projects in Create api Mock Page.

2 participants