Skip to content

Image for Git repos organization corrected in how-to-contribute page#97

Closed
Himanshityagii24 wants to merge 5 commits intomicrocks:masterfrom
Himanshityagii24:Himanshi-dev
Closed

Image for Git repos organization corrected in how-to-contribute page#97
Himanshityagii24 wants to merge 5 commits intomicrocks:masterfrom
Himanshityagii24:Himanshi-dev

Conversation

@Himanshityagii24
Copy link
Contributor

@Himanshityagii24 Himanshityagii24 commented Feb 17, 2025

I have corrected the image of Git repos organization in how-to-contribute page:
image
FIXES: #99

@github-actions
Copy link

👋 @Himanshityagii24

Welcome to the Microcks community! 💖

Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly.

Hope you have a great time there!

🌟 ~~~~~~~~~ 🌟

📢 If you like Microcks, please ⭐ star ⭐ our repo to support it!

🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

@yada yada added the kind/enhancement Enhancement of existing feature label Feb 17, 2025
@yada
Copy link
Member

yada commented Feb 17, 2025

Thanks @Himanshityagii24,

  1. Please an issue to describe the problem and link it to your PR
  2. But please use the same image name and replace it with your update (/assets/images/git-repos-organization.png)
  3. Why are you changing the version in packages? This is not related to the issue you fixed: please remove these changes ;)
  4. Please sign your PR (see the DCO check for details), this is mandatory.

@yada
Copy link
Member

yada commented Feb 17, 2025

Thanks for the update @Himanshityagii24
Still have a useless modification on frontend/package.json
And you need to sign and pass the DCO check, see: microcks/microcks.io#304 (comment)

microcks-bot and others added 5 commits February 17, 2025 22:57
Signed-off-by: microcks-bot <info@microcks.io>
Signed-off-by: Himanshityagii24 <tyagihimanshi241@gmail.com>
Signed-off-by: microcks-bot <info@microcks.io>
Signed-off-by: Himanshityagii24 <tyagihimanshi241@gmail.com>
Signed-off-by: Himanshityagii24 <tyagihimanshi241@gmail.com>
Signed-off-by: Himanshityagii24 <tyagihimanshi241@gmail.com>
Signed-off-by: Himanshityagii24 <tyagihimanshi241@gmail.com>
@yada
Copy link
Member

yada commented Feb 17, 2025

Sorry, but too many commits and changes in your PR are not related to the issue!
https://github.com/microcks/hub.microcks.io/pull/97/commits
https://github.com/microcks/hub.microcks.io/pull/97/files

We can not merge old commits twice and create history tracking issues...
Please fix this, and I'll gladly merge the picture update (only).

@Himanshityagii24
Copy link
Contributor Author

Sorry for the inconvenience.I'll

@Himanshityagii24 Himanshityagii24 deleted the Himanshi-dev branch February 17, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Enhancement of existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct Image for Git-repo-organization

3 participants