refactor: remove WithHostNetworkAccess in favor of GetEndpointForNetwork #58
+24
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastienDegodez
added
the
component/documentation
- Remove obsolete WithHostNetworkAccess extension method - Update README to document GetEndpointForNetwork usage - Add note about ASPIRE_ENABLE_CONTAINER_TUNNEL experimental feature - Remove host.docker.internal references from documentation - Clean up test fixture Signed-off-by: SebastienDegodez <sebastien.degodez@gmail.com>
SebastienDegodez
force-pushed
the
feature/use-get-endpoint-for-network
branch
from
e4c4fa7 to
313817b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WithHostNetworkAccessin favor ofGetEndpointForNetwork(Aspire 13.0+)ASPIRE_ENABLE_CONTAINER_TUNNELexperimental feature requirementRelated issue(s)
See also dotnet/aspire#6547
#57