Skip to content

refactor: remove MacOSHelper and its usage from the codebase #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lbroudoux merged 1 commit into from
Jan 12, 2026
+0 −109
Merged

refactor: remove MacOSHelper and its usage from the codebase #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 0 additions & 54 deletions src/Microcks.Testcontainers/Helpers/MacOSHelper.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/Microcks.Testcontainers/MicrocksBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ private void ContainerStarted(MicrocksContainer container)
protected override MicrocksBuilder Init()
{
return base.Init()
.WithEnvironment(MacOSHelper.GetJavaOptions())
.WithImage(_microcksImage)
.WithPortBinding(MicrocksHttpPort, true)
.WithPortBinding(MicrocksGrpcPort, true)
Expand Down
2 changes: 0 additions & 2 deletions src/Microcks.Testcontainers/MicrocksContainerEnsemble.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ public MicrocksContainerEnsemble(INetwork network, string microcksImage)
.WithNetworkAliases("microcks")
.WithExposedPort(MicrocksBuilder.MicrocksHttpPort)
.WithExposedPort(MicrocksBuilder.MicrocksGrpcPort)
.WithEnvironment(MacOSHelper.GetJavaOptions())
.WithEnvironment("POSTMAN_RUNNER_URL", "http://postman:3000")
.WithEnvironment("TEST_CALLBACK_URL", "http://microcks:" + MicrocksBuilder.MicrocksHttpPort)
.WithEnvironment("ASYNC_MINION_URL", "http://microcks-async-minion:" + MicrocksAsyncMinionBuilder.MicrocksAsyncMinionHttpPort);
Expand Down Expand Up @@ -218,7 +217,6 @@ public MicrocksContainerEnsemble WithAsyncFeature()
}

this._asyncMinionBuilder = new MicrocksAsyncMinionBuilder(this._network)
.WithEnvironment(MacOSHelper.GetJavaOptions())
.WithImage(image);

if (this._debugLogLevelEnabled)
Expand Down
51 changes: 0 additions & 51 deletions tests/Microcks.Testcontainers.Tests/Helpers/MacOSHelperTests.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion tests/Microcks.Testcontainers.Tests/MicrocksContractTestingFunctionalityWithOAuth2Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ public MicrocksContractTestingFunctionalityWithOAuth2Tests(MicrocksContractTesti
_fixture = fixture;
var network = _fixture.Network;
_keycloak = new KeycloakBuilder("quay.io/keycloak/keycloak:26.0.0")
.WithEnvironment(MacOSHelper.GetJavaOptions("JAVA_OPTS_APPEND"))
.WithNetwork(network)
.WithNetworkAliases("keycloak")
.WithCommand("--import-realm")
Expand Down
Loading