refactor: resolve SonarQube code quality issues #212
Merged
+72
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace custom ApplicationJsonMediaType with standard MediaTypeNames.Application.Json - Make ConfigurationConstants class static - Add 'out' keyword to generic parameter for covariance in IArtifactAndSnapshotManager - Make ExtractOperationName method static in MicrocksAsyncMinionContainer - Use nameof() in ArgumentNullException parameter in SecretBuilder - Fix _microcksImage field usage in MicrocksBuilder.Init() - Exclude HTTP localhost URLs in test containers from HTTPS warning (S5332) Signed-off-by: SebastienDegodez <[email protected]>
SebastienDegodez
force-pushed
the
fix/sonar-issue
branch
from
20eadea to
0711363
Compare
|
SebastienDegodez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Proposed Changes
Readiness Checklist
Author/Contributor
dotnet testand ensure you have test coverage for the lines you are introducingdotnet husky runand fix any issues that you have introducedReviewer
feature,fix,documentation,enhancement,maintenanceorbreaking