Merged
Conversation
Signed-off-by: SebastienDegodez <sebastien.degodez@gmail.com>
Signed-off-by: SebastienDegodez <sebastien.degodez@gmail.com>
lbroudoux
added
component/documentation
lbroudoux
reviewed
Jan 15, 2025
lbroudoux
approved these changes
Jan 15, 2025
Member
lbroudoux
left a comment
lbroudoux
left a comment
There was a problem hiding this comment.
Looks all good to me! Thanks for the contribution @SebastienDegodez 🙇♂️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Proposed Changes
This pull request adds support for the WebSocket protocol to the application. The changes include the addition of WebSocket containers for both good and bad implementations in the MicrocksAsyncFeatureTest class. This will allow for testing WebSocket-based asynchronous features.
Additionally, the
MicrocksAsyncMinionBuilderclass has been updated to replace.WithExposedPort(MicrocksAsyncMinionHttpPort)with.WithPortBinding(MicrocksAsyncMinionHttpPort, true)to properly bind the ports for the WebSocket connections.PR: #20
Readiness Checklist
Author/Contributor
dotnet testand ensure you have test coverage for the lines you are introducingdotnet husky runand fix any issues that you have introducedReviewer
feature,fix,documentation,enhancement,maintenanceorbreaking