Skip to content

Adjusted the alignment of toggle in mobile view#283

Merged
yada merged 3 commits intomicrocks:masterfrom
vickybesra:toggle-adjustment
Feb 11, 2025
Merged

Adjusted the alignment of toggle in mobile view#283
yada merged 3 commits intomicrocks:masterfrom
vickybesra:toggle-adjustment

Conversation

@vickybesra
Copy link
Contributor

Description

Fixes:
Screenshot 2025-02-06 at 9 02 49 PM

Related issue(s)
Resolves #278

Signed-off-by: Vicky Besra <vickybesra2000@gmail.com>
@yada yada self-assigned this Feb 7, 2025
Copy link
Member

@yada yada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and .scss fix LGTM.
But do we need the hugo_stats.json update? This file is generated by Hugo (it's in .gitignore, but it doesn’t seem to be ignored as expected...).

@vickybesra
Copy link
Contributor Author

@yada
Yes, I have checked by running it locally that this file is generated by hugo so we don't need it in repo.
Should I create a PR for removing hugo_stats.json from repo?

@yada
Copy link
Member

yada commented Feb 10, 2025

@yada Yes, I have checked by running it locally that this file is generated by hugo so we don't need it in repo. Should I create a PR for removing hugo_stats.json from repo?

Thanks. Could you please update (instead of creating a new one) this PR (without hugo_stats.json)? I'll be happy to merge.

Signed-off-by: Vicky Besra <vickybesra2000@gmail.com>
@vickybesra vickybesra requested a review from yada February 10, 2025 12:08
@yada
Copy link
Member

yada commented Feb 10, 2025

@vickybesra "This branch has conflicts that must be resolved", see "Use the command line to resolve conflicts before continuing" This is a great GIT exercise ;-)
Also see: githubteacher/github-for-developers-sept-2015#648

@vickybesra
Copy link
Contributor Author

@yada PTAL

Copy link
Member

@yada yada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with thanks

@yada yada merged commit 09712ca into microcks:master Feb 11, 2025
1 of 6 checks passed
vickybesra added a commit to vickybesra/microcks.io that referenced this pull request Feb 23, 2025
* Adjusted the alignment of toggle in mobile view

Signed-off-by: Vicky Besra <vickybesra2000@gmail.com>

* removed hugo_stats.json

Signed-off-by: Vicky Besra <vickybesra2000@gmail.com>

---------

Signed-off-by: Vicky Besra <vickybesra2000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Placing the toggle switch to center

2 participants