Fix 274: The search bar in the Docs section needs more left margin#284
Closed
krishi-agrawal wants to merge 12 commits intomicrocks:masterfrom
krishi-agrawal:fixes-274
Closed
Fix 274: The search bar in the Docs section needs more left margin#284krishi-agrawal wants to merge 12 commits intomicrocks:masterfrom krishi-agrawal:fixes-274
krishi-agrawal wants to merge 12 commits intomicrocks:masterfrom
krishi-agrawal:fixes-274
Conversation
Contributor
Author
|
PTAL @yada @lbroudoux |
yada
requested changes
Feb 10, 2025
Member
yada
left a comment
yada
left a comment
There was a problem hiding this comment.
Tested locally and LGTM.
But please sign it, see the DCO check that is mandatory and I will be happy to merge.
Signed-off-by: krishi-agrawal <krishi.agrawal26@gmail.com>
Signed-off-by: krishi-agrawal <krishi.agrawal26@gmail.com>
Signed-off-by: Laurent Broudoux <laurent.broudoux@gmail.com> Signed-off-by: krishi-agrawal <krishi.agrawal26@gmail.com>
Signed-off-by: krishi-agrawal <krishi.agrawal26@gmail.com>
Signed-off-by: Laurent Broudoux <laurent.broudoux@gmail.com> Signed-off-by: krishi-agrawal <krishi.agrawal26@gmail.com>
Signed-off-by: krishi-agrawal <krishi.agrawal26@gmail.com>
Signed-off-by: Laurent Broudoux <laurent.broudoux@gmail.com> Signed-off-by: krishi-agrawal <krishi.agrawal26@gmail.com>
Signed-off-by: krishi-agrawal <krishi.agrawal26@gmail.com>
Signed-off-by: Vicky Besra <vickybesra2000@gmail.com> Signed-off-by: krishi-agrawal <krishi.agrawal26@gmail.com>
Contributor
Author
|
created a new PR which resolves the issue. Closing this PR. |
Member
|
Why do you close this PR, as the only thing to solve is the DCO check (signing your PR) !? |
Contributor
Author
There were new commits pushed into the master branch by the time I started working on the checks. So there were conflicts with the base branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #274
Margin added for dekstop screens.
Margin added for smaller screens
Related issue(s)