Skip to content

fix netlify build error#302

Merged
yada merged 2 commits intomicrocks:masterfrom
vickybesra:fix-netlify
Feb 11, 2025
Merged

fix netlify build error#302
yada merged 2 commits intomicrocks:masterfrom
vickybesra:fix-netlify

Conversation

@vickybesra
Copy link
Contributor

@vickybesra vickybesra commented Feb 10, 2025 •
edited
Loading

Description

  • Fixed Netlify build error.
  • Now preview deploys are built.

Related issue(s)

Fixes #313

@vickybesra
fix hugo.toml
1fec1c7 
Signed-off-by: Vicky Besra <vickybesra2000@gmail.com>
@vickybesra
fix
ccf14af 
Signed-off-by: Vicky Besra <vickybesra2000@gmail.com>
@vickybesra vickybesra marked this pull request as ready for review February 10, 2025 17:12
@vickybesra
Copy link
Contributor Author

vickybesra commented Feb 10, 2025

@yada @lbroudoux For what vercel is used? If not needed can we remove it?

@yada
Copy link
Member

yada commented Feb 11, 2025

@yada @lbroudoux For what vercel is used? If not needed can we remove it?

Good question as I think it has been introduced during the documentation refactoring process... but this PR fix netlify previous so maybe not of use anymore... could you please open a dedicated issue on this and tag us: so we can double check and agree all together on this specific point ;)

@yada yada self-assigned this Feb 11, 2025
yada
yada approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@yada yada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with thanks

@yada yada merged commit cc78b0d into microcks:master Feb 11, 2025
5 of 6 checks passed
@vickybesra
Copy link
Contributor Author

vickybesra commented Feb 11, 2025 •
edited
Loading

@yada @lbroudoux For what vercel is used? If not needed can we remove it?

Good question as I think it has been introduced during the documentation refactoring process... but this PR fix netlify previous so maybe not of use anymore... could you please open a dedicated issue on this and tag us: so we can double check and agree all together on this specific point ;)

Sure

@yada yada mentioned this pull request Feb 11, 2025
Closed
@lbroudoux
Copy link
Member

lbroudoux commented Feb 11, 2025 •
edited
Loading

Yes. I can confirm it was introduced during doc refactoring and can now be removed. I'll disable it tomorrow.

@yada
Copy link
Member

yada commented Feb 11, 2025 •
edited
Loading

I noticed that Netlify builds are passing, but the previews do not reflect the PR (branch) changes! This could be very useful for PR review ;-)

@lbroudoux This seems to be a setting on our side, ref: https://answers.netlify.com/t/do-deploy-previews-re-deploy-when-you-push-a-new-commit/24355/4

@vickybesra vickybesra mentioned this pull request Feb 12, 2025
Closed
This was referenced Feb 14, 2025
Closed
Open
vickybesra added a commit to vickybesra/microcks.io that referenced this pull request Feb 23, 2025
@vickybesra
fix netlify build error (microcks#302)
ea42bd7 
* fix hugo.toml

Signed-off-by: Vicky Besra <vickybesra2000@gmail.com>

* fix

Signed-off-by: Vicky Besra <vickybesra2000@gmail.com>

---------

Signed-off-by: Vicky Besra <vickybesra2000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yada yada yada approved these changes

Assignees

@yada yada

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Errors in CI

3 participants

@vickybesra @yada @lbroudoux