Merged
Conversation
Walkthrough今回の変更は、 Changes
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/types.ts (1)
65-65: MicroCMSImageインターフェースへalt属性の追加は適切です!新しく追加された
alt?プロパティは画像のアクセシビリティを向上させる重要な属性です。オプショナルとして実装されているため、後方互換性も維持されています。より明確にするために、プロパティのドキュメントを追加すると良いかもしれません:
export interface MicroCMSImage { url: string; width?: number; height?: number; + /** + * 画像の代替テキスト(アクセシビリティのため) + */ alt?: string; }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
メディアのalt機能のリリースに合わせた型の追加です。
既存のalt, 未入力のaltについてはaltの値は存在しないため、それに合わせた型となっています。
Summary by CodeRabbit