Conversation
|
Caution Review failedThe pull request is closed. WalkthroughGitHub Actions ワークフローを更新し、アクション参照を特定コミットSHAへ変更、トリガーのクォート形式を統一、CI を静的チェックと拡張された Node.js マトリックス(18.x,20.x,22.x,24.x)で分離。package.json にフォーマット・型チェックスクリプトを追加し、テストモックの MSW 呼び出しを整形/分割。 Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant GH as GitHub Actions
participant Repo as Repository
participant Node as Node matrix jobs
rect rgb(230,245,255)
Note over GH,Repo: Push / pull_request / release trigger
end
GH->>Repo: checkout (specific SHA)
GH->>GH: static-check job
GH->>Node: build-and-test job (matrix: 18x,20x,22x,24x)
Node->>GH: run Build
Node->>GH: run Unit Tests
GH->>GH: publish (release workflow)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 確認が必要な箇所:
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
Comment |
nemuvski
commented
Nov 6, 2025
Comment on lines
-12
to
+13
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | ||
| - uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0 |
Member
Author
There was a problem hiding this comment.
バージョンアップと同時に、pinactでコミットハッシュで固定しました。
nemuvski
commented
Nov 6, 2025
Comment on lines
-15
to
+16
| node-version: '18.x' | ||
| registry-url: 'https://registry.npmjs.org' | ||
| node-version-file: ".node-version" | ||
| registry-url: "https://registry.npmjs.org" |
Member
Author
There was a problem hiding this comment.
バージョン指定を .node-version ファイルを読むようにしました。
追伸: フォーマットかかっていて、クオーテーションが変わってますが気にせずで。
nemuvski
commented
Nov 6, 2025
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x] | ||
| node-version: [18.x, 20.x, 22.x, 24.x] |
Member
Author
There was a problem hiding this comment.
現行で、24まで出ているので、加えておきました。
コードチェック強化: format, typecheck追加, eslintにtestsディレクトリを対象に加える
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更概要
actions/checkoutとactions/setup-nodeの最新を利用する.github/workflows/ci.ymlstrategy.matrix.node-versionに 22.x と 24.x を追記.github/workflows/release.yml.node-versionファイルを読む先に #94 をみてください。
Summary by CodeRabbit
Chores
Chores(パッケージ)
Tests