Nodeのアップデート + NPM Publishの方法をセキュアなものに変更 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nemuvski
reviewed
Nov 12, 2025
.github/workflows/npm-publish.yml
Outdated
Comment on lines
14
to
15
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 |
Member
There was a problem hiding this comment.
[NITPICK]
nodeバージョン上げから外れてしまって恐縮ですが
お手隙で大丈夫です。
pinactでバージョンをハッシュで固定しておくのが安全です 🙏
nemuvski
reviewed
Nov 12, 2025
Member
nemuvski
left a comment
nemuvski
left a comment
There was a problem hiding this comment.
１つ確認です
今回のコミットはNodeバージョン上げのみで、permissionの指定はせずで問題ないですか？
… permissions for OIDC
dc7290
changed the title
nemuvski
approved these changes
Nov 12, 2025
Member
nemuvski
left a comment
nemuvski
left a comment
There was a problem hiding this comment.
修正コミットありがとうございます！
permissions&トークンレスにした点 チェックしました！
(バージョンのハッシュ指定もありがとうございます)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.