Conversation
play-services-core/src/main/kotlin/org/microg/gms/accountaction/ErrorResolver.kt
Outdated
Show resolved
Hide resolved
|
Nice! Great to see this fixed 😭😭😭 |
fynngodau
left a comment
There was a problem hiding this comment.
Many thanks for implementing this feature. However, as a regression, the UserSatisfyRequirements resolution feature no longer works with these changes.
play-services-core/src/main/kotlin/org/microg/gms/accountaction/AccountActionActivity.kt
Outdated
Show resolved
Hide resolved
play-services-core/src/main/kotlin/org/microg/gms/accountaction/ErrorResolver.kt
Outdated
Show resolved
Hide resolved
play-services-core/src/main/kotlin/org/microg/gms/accountaction/Resolution.kt
Outdated
Show resolved
Hide resolved
play-services-core/src/main/kotlin/org/microg/gms/accountaction/AccountActionActivity.kt
Outdated
Show resolved
Hide resolved
|
One thing I noticed is that reauth is not possible if Android ID has changed (i.e. when microG data has been deleted, but accounts were kept). This should be relatively easy to fix, but I don't think it needs to be solved in this PR. 🙂 |
|
When testing this PR, I removed some specific devices from the Security tab in myaccount. A few days later, unrelated to this PR, I was not able to sign in (or reauth) from microG until I changed Android ID; perhaps the device was locked out in a way microG is unable to recover from? The server response was only a generic error. |
Co-authored-by: Lucas <55422065+lucasmz-dev@users.noreply.github.com>
Co-authored-by: Lucas <55422065+lucasmz-dev@users.noreply.github.com>
Co-authored-by: Lucas <55422065+lucasmz-dev@users.noreply.github.com>
bbb42a5 to
ce73cce
Compare
Co-authored-by: Lucas <55422065+lucasmz-dev@users.noreply.github.com>
#2731 (comment)
Based on @fynngodau’s solution, use notifications to inform users whether their account has expired. Users can choose to log in again or log out.
Choosing to re-login will be handled based on the newly added reauth interface.