Skip to content

Improved readme #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ale5000-git wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improved readme #147

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cba622
Improved readme
ale5000-git Jan 6, 2018
5e2a8c6
Fixed error in the text
ale5000-git Jan 6, 2018
414673b
Minor change in the text
ale5000-git Jan 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ On these systems installation is easy:
2. Download and install `NetworkLocation.apk` as a usual app (you may need to enable "Unknown sources" in Settings->Security)
3. Reboot and continue at [Usage](#usage)

**Important:** Installing as system app will always works, instead installing as user app will only works out of the box on Android versions from 4.4 to 6.x.
**Important:** Installing as system app will always works, instead installing as user app will only work out of the box on Android versions from 4.4 to 6.x.
Copy link

@JonnyTech JonnyTech Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly improve grammar:

Installing as a system app will always work for all versions of Android. But installing as user app will only work on Android versions 4.4 to 6.x.

Copy link
Member Author

@ale5000-git ale5000-git Jan 8, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have kept "out of the box" because it means without changes, you can make it working (but not out of the box).

Copy link

@IzzySoft IzzySoft Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also strike the "s" in "will always works" (→ "will always work") :)

Copy link
Member Author

@ale5000-git ale5000-git Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already corrected it when I have talked about "out of the box".

On Android 7 (or higher) can be used also as user app if you compile the ROM with an [additional patch](https://github.com/microg/android_packages_apps_UnifiedNlp/blob/master/patches/android_frameworks_base-N.patch).

**Note:** Android versions lower then 4.4 are no longer officially supported, however I still provide a legacy build that should be compatible with those systems.
Expand Down