Skip to content

Feature#1

Open
hassanShakur wants to merge 8 commits intodevfrom
feature
Open

Feature#1
hassanShakur wants to merge 8 commits intodevfrom
feature

Conversation

@hassanShakur
Copy link
Member

In this branch, I implemented the following requirements:

  • Create a new Rails API app called 'hello-rails-back-end'.
  • Initialize your project with Git.
  • Make sure that your project has a Postgres database set up.
  • Create a table for storing your messages and create 5 different greetings.
  • Create an API endpoint that selects a random greeting from your table (you will need a controller with an action and rails route).

Copy link

@t-yanick t-yanick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: MILESTONE APPROVED 🥇

Hi @hassanShakur ,

Great job !!!

To Highlight! 👏 🟢

✔️ API endpoint for returning a random greeting created
✔️ Database table for storing different greetings created
✔️ Frontend repo found in readme
✔️ Apps work together

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

  • See frontend for changes

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants