Skip to content

Commit d28e8fc

Browse files
Fixing meta release
1 parent 5af949c commit d28e8fc

File tree

6 files changed

+39
-16
lines changed

6 files changed

+39
-16
lines changed

src/main/java/io/micrometer/release/Main.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -113,15 +113,19 @@ MetaTrainReleaseWorkflow metaReleaseWorkflow(PostReleaseWorkflow postReleaseWork
113113

114114
private List<ProjectSetup> parseMetaTrainOptions(boolean testMode, String contextPropVersions,
115115
String micrometerVersions, String tracingVersions, String docsGenVersions) {
116-
return TrainOptions.withTestMode(testMode)
116+
List<ProjectSetup> projectSetups = TrainOptions.withTestMode(testMode)
117117
.parseForMetaTrain(contextPropVersions, micrometerVersions, tracingVersions, docsGenVersions);
118+
log.info("Parsed options for meta-release {}", projectSetups);
119+
return projectSetups;
118120
}
119121

120122
private ProjectSetup parseTrainOptions(boolean testMode, String githubOrgRepo, String contextPropVersions,
121123
String micrometerVersions, String tracingVersions, String docsGenVersions) {
122-
return TrainOptions.withTestMode(testMode)
124+
ProjectSetup setup = TrainOptions.withTestMode(testMode)
123125
.parseForSingleProjectTrain(githubOrgRepo, contextPropVersions, micrometerVersions, tracingVersions,
124126
docsGenVersions);
127+
log.info("Parsed options for meta-release [{}]", setup);
128+
return setup;
125129
}
126130

127131
private boolean isMetaRelease(String githubOrgRepo, String contextPropVersions, String micrometerVersions,
@@ -135,7 +139,7 @@ private boolean isTrainRelease(String githubOrgRepo, String contextPropVersions,
135139
return switch (githubOrgRepo) {
136140
case "micrometer-metrics/context-propagation" -> hasText(contextPropVersions);
137141
case "micrometer-metrics/micrometer", "marcingrzejszczak/gh-actions-test" -> hasText(micrometerVersions);
138-
case "micrometer-metrics/tracing" -> hasText(tracingVersions);
142+
case "micrometer-metrics/tracing", "marcingrzejszczak/gh-actions-test2" -> hasText(tracingVersions);
139143
case "micrometer-metrics/micrometer-docs-generator" -> hasText(docsGenVersions);
140144
default -> false;
141145
};

src/main/java/io/micrometer/release/meta/MetaTrainReleaseWorkflow.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,9 @@ public void run(List<ProjectSetup> projectSetups) {
4949

5050
private ProjectTrainReleaseWorkflow newProjectTrainReleaseWorkflow(ProjectSetup projectSetup) {
5151
File projectSubfolder = new File(projectSetup.ghRepo());
52-
log.info("Creating a subfolder [{}] for project [{}]", projectSubfolder, projectSetup.ghOrgRepo());
52+
projectSubfolder.mkdirs();
53+
log.info("Setting a working dir [{}] for project [{}]", projectSubfolder.getAbsolutePath(),
54+
projectSetup.ghOrgRepo());
5355
return workflow(projectSetup, projectSubfolder);
5456
}
5557

src/main/java/io/micrometer/release/train/Git.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,9 @@ void changeTag(String tag) {
3636
}
3737

3838
File cloneRepo(String branch, String orgRepository) {
39-
// micrometer-metrics/micrometer -> micrometer-metrics_micrometer
40-
String folderToCloneTo = orgRepository.replace("/", "_");
41-
log.info("Cloning out {} branch to folder {}", branch, folderToCloneTo);
42-
processRunner.run("gh", "repo", "clone", orgRepository, folderToCloneTo, "--", "-b", branch, "--single-branch");
43-
return clonedDir(folderToCloneTo);
39+
log.info("Cloning out {} branch to folder {}", branch, branch);
40+
processRunner.run("gh", "repo", "clone", orgRepository, branch, "--", "-b", branch, "--single-branch");
41+
return clonedDir(branch);
4442
}
4543

4644
File clonedDir(String subfolder) {

src/main/java/io/micrometer/release/train/TrainOptions.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,12 @@ public List<ProjectSetup> parseForMetaTrain(String contextPropagationVersions, S
4545
List<ProjectWithDependencies> projects = projectWithDependencies(splitProjects);
4646
Map<ProjectDefinition, List<ProjectWithDependencies>> perProject = projects.stream()
4747
.collect(Collectors.groupingBy(p -> p.project.projectDefinition));
48-
return perProject.entrySet()
49-
.stream()
48+
return perProject.entrySet().stream().filter(e -> {
49+
if (testMode) {
50+
return e.getKey() == ProjectDefinition.TEST || e.getKey() == ProjectDefinition.TRACING_TEST;
51+
}
52+
return true;
53+
})
5054
.map(e -> new ProjectSetup(e.getValue(), e.getKey().orgRepo))
5155
.sorted(Comparator.comparingInt(o -> o.thisProject.get(0).project.projectDefinition.ordinal())) // ORDER
5256
// MATTERS!!!!
@@ -346,7 +350,8 @@ public GhActionsTest(Micrometer micrometer) {
346350
static class GhActionsTracingTest extends ProjectWithDependencies {
347351

348352
public GhActionsTracingTest(Tracing tracing) {
349-
super(new Project(ProjectDefinition.TEST, tracing.getProject().projectVersion), tracing.getDependencies());
353+
super(new Project(ProjectDefinition.TRACING_TEST, tracing.getProject().projectVersion),
354+
tracing.getDependencies());
350355
}
351356

352357
}

src/test/java/io/micrometer/release/train/GitTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ void should_clone_a_repo() {
4040
git.cloneRepo("foo", "micrometer-metrics/micrometer");
4141

4242
then(processRunner).should()
43-
.run("gh", "repo", "clone", "micrometer-metrics/micrometer", "micrometer-metrics_micrometer", "--", "-b",
44-
"foo", "--single-branch");
43+
.run("gh", "repo", "clone", "micrometer-metrics/micrometer", "foo", "--", "-b", "foo", "--single-branch");
4544
}
4645

4746
}

src/test/java/io/micrometer/release/train/TrainOptionsTests.java

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,25 @@ void should_parse_for_meta_train_entries_to_project_setup(String contextPropagat
138138
then(projectSetups).isEqualTo(expectedResult);
139139
}
140140

141+
@Test
142+
void should_parse_for_meta_train_entries_to_project_setup_for_test_project() {
143+
String contextPropagationVersions = "";
144+
String micrometerVersions = "1.1.0";
145+
String tracingVersions = "2.0.0";
146+
String docsGenVersions = "";
147+
148+
List<ProjectSetup> projectSetups = TrainOptions.withTestMode(true)
149+
.parseForMetaTrain(contextPropagationVersions, micrometerVersions, tracingVersions, docsGenVersions);
150+
151+
then(projectSetups).hasSize(2);
152+
then(projectSetups.get(0).ghRepo()).isEqualTo("gh-actions-test");
153+
then(projectSetups.get(1).ghRepo()).isEqualTo("gh-actions-test2");
154+
}
155+
141156
static Stream<Arguments> should_parse_for_meta_train_entries_to_project_setup_args() {
142157
return Stream.of(
143-
// Arguments.of("1.0.0,1.1.0,1.1.1", "", "", "",
144-
// List.of(singleContextPropagation("micrometer-metrics/context-propagation"))),
158+
Arguments.of("1.0.0,1.1.0,1.1.1", "", "", "",
159+
List.of(singleContextPropagation("micrometer-metrics/context-propagation"))),
145160
Arguments.of("1.0.0,1.1.0,1.1.1", "1.14.0,1.15.0,1.16.0", "", "",
146161
List.of(contextAndMicrometer("micrometer-metrics/context-propagation"),
147162
contextAndMicrometer("micrometer-metrics/micrometer"))),

0 commit comments

Comments
 (0)