Resolve MissingOverride warnings from Error Prone #6143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johnny Lim <[email protected]>
izeye
commented
Apr 19, 2025
| */ | ||
| @Override | ||
| @Nullable | ||
| String get(String key); |
There was a problem hiding this comment.
I wanted to remove these, but I couldn't due to binary compatibility check failures.
I created #6145 instead.
shakuzen
added
the
polish
shakuzen
approved these changes
Apr 21, 2025
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Apr 25, 2025
This commit also changes to handle BadImport, DefaultCharset, and MissingOverride as errors. See micrometer-metricsgh-6143 See micrometer-metricsgh-6154 Signed-off-by: Johnny Lim <[email protected]>
jonatan-ivanov
pushed a commit
that referenced
this pull request
Apr 25, 2025
This commit also changes to handle BadImport, DefaultCharset, and MissingOverride as errors. See gh-6143 See gh-6154 Signed-off-by: Johnny Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to resolve "MissingOverride" warnings from the Error Prone.