Allow Prometheus meters with the same name but a different set of tag keys#7168
Draft
shakuzen wants to merge 1 commit intomicrometer-metrics:mainfrom
Draft
Allow Prometheus meters with the same name but a different set of tag keys#7168shakuzen wants to merge 1 commit intomicrometer-metrics:mainfrom
shakuzen wants to merge 1 commit intomicrometer-metrics:mainfrom
Conversation
shakuzen
force-pushed
the
prom-mismatch-labels
branch
from
e570caa to
9d3a71e
Compare
shakuzen
changed the title
Allow registering meters with the same name but a different set of tag keys. This used to be disallowed by the Prometheus Java client but is supported since 1.5.0.
shakuzen
force-pushed
the
prom-mismatch-labels
branch
from
9d3a71e to
bc38446
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prometheus 1.5.0 will lift the restriction that prevented this. See prometheus/client_java#696.
TODO: Upgrade to Prometheus Java 1.5.0 release version when available
TODO: Update documentation