Move away from Jackson

[timyates]

Started with function-aws-api-proxy to gather feedback

• Is this going in the right direction?
• Are request bodies always Maps in Lambdas? I couldn't find a way to parse a JsonNode here
• I had to @SerdeImport` quite a few AWS classes, but I'm not sure our coverage has shown them all
• I had to write my own replacements for ObjectWriter and ObjectReader

When I look at a scan for running the tests, I still see a LOT of Jackson, so I'm not sure if I'm doing the right thing

https://ge.micronaut.io/s/s7dmxjatvn6c4/dependencies?dependencies=fasterxml&expandAll

[sdelamo]

This will be a breaking change. We have to do it for next mayor of AWS.

[sdelamo]

I would recommend to update the build to 3.4.0, githubCoreBranch to 3.5.0 and use the serde version in the BOM.

[sdelamo]

There is a import io.micronaut.serde.ObjectMapper;. Why not return it instead?

[sdelamo]

There is a import io.micronaut.serde.ObjectMapper; why not use instead of JsonMapper?

[timyates]

JsonCodec returns a JsonMapper, which isn't an ObjectMapper 😔

[sdelamo]

why not use import io.micronaut.serde.ObjectMapper instead?

[sdelamo]

@yawkat can you provide feedback?

[timyates]

We can't decode to a serde JsonNode here (it fails to create one), so I fell back to a Map. This will break if the body is not a map (ie: a simple json string), but I'm not sure if Lambdas can receive simple strings

[timyates]

The HateOas model doesn't seem to be coming through correctly...

{"message":"Internal Server Error","_links":{"self":[{"href":"https://null.execute-api.us-east-1.amazonaws.com/filter-error-spec-3","templated":false}]},"_embedded":{"errors":[{}]}}

Notice the errors are not serialized with any properties...

I've tried @SerdeImport(JsonError.class) but it has no effect on the result

The model should look like this:

[timyates]

@alvarosanchez Any idea how we migrate this to Serde serialization? The tests are checking for Jackson features which I don't believe we support in Serde

[alvarosanchez]

This was the original reason for that code.

If you are removing Jackson from here, then I don't think that feature is needed at all. Note that this change requires a new major version of the module.

[timyates]

@alvarosanchez Thanks! We're well into new major version territory already, so that should be fine 👍

[timyates]

So here

micronaut-aws/aws-alexa-httpserver/src/test/groovy/io/micronaut/aws/alexa/httpserver/controllers/SkillControllerPathSpec.groovy

Lines 42 to 45 in dca8a6c

	RequestEnvelope re = launchRequestEnvelop(skillId)
	HttpRequest request = HttpRequest.POST("/computer", re)
	HttpResponse<ResponseEnvelope> response = client.exchange(request, ResponseEnvelope)

We send an AWS RequestEnvelope(link), and expect an AWS ResponseEnvelope in return.

Serde fails to deserialize the request model as No default constructor exists... I'm going to look into a custom deserializer

[timyates]

@graemerocher @yawkat I'm not sure how to use Serde to handle RequestEnvelope from AWS (see #1323 (comment) above)

The class iteself and a lot of it's member classes use

@JsonDeserialize(builder = RequestEnvelope.Builder.class)

Which we don't support in Serde 🤔. Anyone got any ideas about getting round this?

[yawkat]

@timyates i would use a JsonCreator in a mixin

[timyates]

@yawkat Like this?

public class RequestEnvelopeMixin {

    @JsonCreator
    public static RequestEnvelope factory(
            @JsonProperty("version") String version,
            @JsonProperty("session") Session session,
            @JsonProperty("context") Context context,
            @JsonProperty("request") Request request
    ) {
        return RequestEnvelope.builder()
                .withVersion(version)
                .withSession(session)
                .withContext(context)
                .withRequest(request)
                .build();
    }
}

I guess I need to mixin the whole tree of types before it will start working 😀

[yawkat]

sure something like that. But yea looking at the other classes, this seems infeasible

[graemerocher]

A custom deserializer is probably the simplest to be honest

[yawkat]

@graemerocher the classes only get bigger, see eg https://github.com/alexa/alexa-apis-for-java/blob/master/ask-sdk-model/src/com/amazon/ask/model/Context.java

[graemerocher]

seems like we are going to have to add support for builder=

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

66.7% Coverage
0.0% Duplication

[timyates]

Currently blocked by micronaut-projects/micronaut-serialization#176

[lesteenman]

The blocking issue seems closed; Any intentions to continue work on this?